search

bripkens / health-check-adapter

Connect health check endpoints to Slack
Apache License 2.0
3 stars 3 forks source link

Unhandled messages #10

Closed britter closed 8 years ago

britter commented 8 years ago

Akka's default behavior for unhandled messages is to send a akka.actor.UnhandledMessage to the actor system's global event stream. By handling even the unknown messages in our actor implementations, we're breaking this fall back.

This PR changes the implemenation of all receive methods to ignore unknown messages so that they can be handled by the actor system instead.

bripkens commented 8 years ago

What does the actor system do when it receives an unknown message?

britter commented 8 years ago

They will be published to the system's event stream. You can enable debug logging of handled messages by setting the akka.actor.debug.unhandled configuration setting to ON

bripkens commented 8 years ago

Can we provide this as a default configuration? I'd hate to swallow such errors.

britter commented 8 years ago

Sure!

bripkens commented 8 years ago

LGTM. Feel free to merge! :)