bripkens / lucene

Node.js lib to transform: lucene query → syntax tree → lucene query
MIT License
72 stars 33 forks source link

Fix for https://github.com/bripkens/lucene/issues/9 #10

Closed Lotti closed 6 years ago

Lotti commented 6 years ago

Don't know if everything is in place... automated tests seems to hold. Probably not the most elegant and effective solution on on the peg grammar but.. it was my first time and I just copy pasted (don't know anything about PEG syntax).

I've added for both parse and to_string:

with their relative tests too.

Please review :)

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 79.756% when pulling 5e515c38f56344378fa5fe4ca1829e73877b3823 on Lotti:master into cc6197c6271f0b01b4cf97708ddc0513cb05a12c on bripkens:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 79.756% when pulling 90ff8ece22ae4e4afee0aba633b9b9520d80f841 on Lotti:master into cc6197c6271f0b01b4cf97708ddc0513cb05a12c on bripkens:master.

bripkens commented 6 years ago

Looks great to me. Thank you for this nice contribution. Will merge and release asap! :)

bripkens commented 6 years ago

Released as version 1.2.0. Thank you @Lotti!