search

bripkens / lucene

Node.js lib to transform: lucene query → syntax tree → lucene query
MIT License
72 stars 33 forks source link

fix for quoted empty string #17

Closed nicolashenry closed 6 years ago

nicolashenry commented 6 years ago 
{
    field: 'myfield',
    term: '',
    quoted: true
}

currently generates myfield:

This pull request makes it generate myfield:"" instead.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 80.357% when pulling 5185f1c743ccf0b93c6f3094551800a473999b31 on nicolashenry:patch-2 into be5c450a3ec9d9d8d4bb96a20c4e974202676d73 on bripkens:master.

bripkens commented 6 years ago

Thank you very much @nicolashenry. Change looks great 👌 !

I merged it manually in 28defcf07e01918288492ec66de819decd2c7098 and added test cases and a changelog entry for completeness.

bripkens commented 6 years ago

Released as 2.0.0: https://github.com/bripkens/lucene/blob/master/CHANGELOG.md#200