brisa-build / brisa

The Web Platform Framework.
https://brisa.build
MIT License
449 stars 12 forks source link

Form action should work without JavaScript #595

Closed aralroca closed 3 weeks ago

aralroca commented 3 weeks ago

After the change of the indicator:

https://github.com/brisa-build/brisa/pull/585

but the indicator usage in the Brisa core introduces an issue, since it looks at the header of x-action to know if it is an action. This header is not being set in case of not having JavaScript, and the form actions should still work.

aralroca commented 3 weeks ago

@lattaai2 This is-an-action is for attribute detection, since we support action propagation in rendering. But it has nothing to do with the detection of processing a POST action request from a form. Thanks anyway for trying to fix it. This was working fine before, behind this PR the bug was added. The best thing to do is to fix the getIndicator. In fact I had assigned me the issue because I have clear the fix part.