bristlemouth / bm_protocol

Primary Bristlemouth firmware repository
https://www.bristlemouth.org/
Apache License 2.0
10 stars 7 forks source link

fix: rbr range to spec #120

Closed towynlin closed 4 months ago

towynlin commented 4 months ago

Also ended up fixing a misplaced cbor_value_advance when the bridge, during aggregation, is determining the type of RBR sensor that is connected to a module downstream. The code would have worked previously if rbrCodaType was the first sys cfg key in the cbor map, but it failed to detect the type when it needed to advance past non-matching keys. Also found that latest_sensor_type in the RBR sensor driver was never being set.

Bridge log snippet during aggregation after the fix:

[BM_COMMON_IND] 8b718c26aea126dc,1,RBR.DT,182999,1711486984.160,182.999,-35.000,199.000
RBR CODA data received from node 8b718c26aea126dc On topic: sensor/8b718c26aea126dc/sofar/bm_rbr_data
[BM_COMMON_IND] 8b718c26aea126dc,1,RBR.DT,183509,1711486984.667,183.509,-34.000,198.000
RBR CODA data received from node 8b718c26aea126dc On topic: sensor/8b718c26aea126dc/sofar/bm_rbr_data
[BM_COMMON_IND] 8b718c26aea126dc,1,RBR.DT,184019,1711486985.179,184.019,-33.000,198.500
Bridge State Sampling Off until 1711487100 epoch seconds
Adin paused, ignoring event 2
Powered device 0 : off
Bridge bus power: 0
Controller task will wait 115000 ms
Aggregation period done!
RBR Node app name: bm_rbr-dbg
Git SHA: 704bf10a
sys_confg_crc: 152998d
rbrCodaType: 3
RBR type RBR.DT
[BM_COMMON_AGG] 8b718c26aea126dc,1,RBR.DT,1711486985.593,521,-inf,198.874,0.739
Adding sample for 8b718c26aea126dc to list
Incrementing sample counter to 1
Found data for node 8b718c26aea126dc adding it to the the report
Clearing the list
Clearing the sample counter