search

bristlemouth / bm_protocol

Primary Bristlemouth firmware repository
https://www.bristlemouth.org/
Apache License 2.0
12 stars 8 forks source link

Bugfix/fixing difference signal #138

Closed russelldeguzman closed 5 months ago

russelldeguzman commented 5 months ago

Fixing No 1. and 2. Here: https://github.com/bristlemouth/bm_protocol/pull/137#issuecomment-2123577873

russelldeguzman commented 5 months ago

@towynlin See test/src/common/differenceSignal_ut.cpp:52,69!

I now think you're planning to encode it in a bitpacked message separately, outside this lib. Is that correct

Yes - That's correct!

evanShap commented 5 months ago

Should probably add a unit test for getReferenceSignal.

I was expecting to see the reference signal encoded into the buffer, but I now think you're planning to encode it in a bitpacked message separately, outside this lib. Is that correct?

Isabel is working on the data analysis, but right now the thinking is we're probably going to ditch the residuals - we don't really need them.