search

bristlemouth / bm_protocol

Primary Bristlemouth firmware repository
https://www.bristlemouth.org/
Apache License 2.0
10 stars 7 forks source link

only set ms from rtc if we have rtc #143

Closed victorsowa12 closed 1 month ago

victorsowa12 commented 1 month ago

If we didn't have RTC fixed, the RBR sens ind lines would have an unset default value for the UTC ms column.

Before FIX
ac84979e1f96729f,1,RBR.D,27348,6593470336.000,26.500,nan,10.131
ac84979e1f96729f,1,RBR.D,27848,6593470336.000,27.000,nan,10.131
ac84979e1f96729f,1,RBR.D,28348,6593470336.000,27.500,nan,10.130
ac84979e1f96729f,1,RBR.D,28848,6593470336.000,28.000,nan,10.131
ac84979e1f96729f,1,RBR.D,29348,6593470336.000,28.500,nan,10.131
ac84979e1f96729f,1,RBR.D,29848,6593470336.000,29.000,nan,10.131
ac84979e1f96729f,1,RBR.D,30348,6593470336.000,29.500,nan,10.131
ac84979e1f96729f,1,RBR.D,30848,6593470336.000,30.000,nan,10.131
AFTER FIX
ac84979e1f96729f,1,RBR.D,1016,0.000,0.000,nan,10.130
ac84979e1f96729f,1,RBR.D,1338,0.000,0.500,nan,10.130
ac84979e1f96729f,1,RBR.D,1838,0.000,1.000,nan,10.131
ac84979e1f96729f,1,RBR.D,2338,0.000,1.500,nan,10.131
ac84979e1f96729f,1,RBR.D,2838,0.000,2.000,nan,10.131
ac84979e1f96729f,1,RBR.D,3338,0.000,2.500,nan,10.131
ac84979e1f96729f,1,RBR.D,3838,0.000,3.000,nan,10.131

https://app.shortcut.com/sofar/story/203386/on-the-mote-rbr-code-check-if-rtc-valid-before-stamping-data

victorsowa12 commented 1 month ago

Using isRTCSet, we get 0 as expected!

bm_node_id,node_position,node_app_name,reading_uptime_millis,reading_time_utc_s,sensor_reading_time_s
ac84979e1f96729f,1,RBR.D,3937,0.000,3.000,nan,10.132
ac84979e1f96729f,1,RBR.D,4437,0.000,3.500,nan,10.132
ac84979e1f96729f,1,RBR.D,4937,0.000,4.000,nan,10.132
ac84979e1f96729f,1,RBR.D,5437,0.000,4.500,nan,10.132
ac84979e1f96729f,1,RBR.D,5937,0.000,5.000,nan,10.132
ac84979e1f96729f,1,RBR.D,6437,0.000,5.500,nan,10.132
ac84979e1f96729f,1,RBR.D,6937,0.000,6.000,nan,10.132
ac84979e1f96729f,1,RBR.D,7437,0.000,6.500,nan,10.131
ac84979e1f96729f,1,RBR.D,7937,0.000,7.000,nan,10.132
ac84979e1f96729f,1,RBR.D,8437,0.000,7.500,nan,10.132
ac84979e1f96729f,1,RBR.D,8937,0.000,8.000,nan,10.132
ac84979e1f96729f,1,RBR.D,9437,0.000,8.500,nan,10.131
ac84979e1f96729f,1,RBR.D,9937,0.000,9.000,nan,10.132
ac84979e1f96729f,1,RBR.D,10437,0.000,9.500,nan,10.132
ac84979e1f96729f,1,RBR.D,10937,0.000,10.000,nan,10.132
ac84979e1f96729f,1,RBR.D,11437,0.000,10.500,nan,10.131
ac84979e1f96729f,1,RBR.D,11937,0.000,11.000,nan,10.132
ac84979e1f96729f,1,RBR.D,12437,0.000,11.500,nan,10.132
ac84979e1f96729f,1,RBR.D,12937,0.000,12.000,nan,10.132
ac84979e1f96729f,1,RBR.D,13437,0.000,12.500,nan,10.132
ac84979e1f96729f,1,RBR.D,13937,0.000,13.000,nan,10.132
ac84979e1f96729f,1,RBR.D,14437,0.000,13.500,nan,10.132
ac84979e1f96729f,1,RBR.D,14937,0.000,14.000,nan,10.132
ac84979e1f96729f,1,RBR.D,15437,0.000,14.500,nan,10.132