search

bristolcrypto / HEAT

BSD 2-Clause "Simplified" License
26 stars 7 forks source link

The bug of deciding NTL version in HElib. #4

Closed NanXiao closed 7 years ago

NanXiao commented 7 years ago

Now, the HEAT's HElib has a bug in NumbTh.h: 

// Test for the "right version" of NTL (currently 9.4.0)
#if ((NTL_MAJOR_VERSION<9)||(NTL_MINOR_VERSION<4)||(NTL_REVISION<0))
#error "This version of HElib requires NTL version 9.4.0 or above"
#endif

If the NTL's version is 10.3.0, Helib will also report error. So I think HEAT should use the newest HElib in which the NumbTh.h has been changed: 

// Test for the "right version" of NTL (currently 9.4.0)
#if ((NTL_MAJOR_VERSION<9)||(NTL_MAJOR_VERSION==9 && NTL_MINOR_VERSION<4))
#error "This version of HElib requires NTL version 9.4.0 or above"
#endif
svivekv commented 7 years ago

Note that HElib has been included as a git submodule and hence can be independently updated.

NanXiao commented 7 years ago

But if the user use git clone --recursive command to clone HEAT, the HElib with the bug version will be cloned, and this HElib is not of a out-of-box product, and need to be updated to the newest Helib. I think this violates the original intention of HEAT.

Thanks!

svivekv commented 7 years ago

Okay. Will fix this.