brisvag / blik

Python tool for visualising and interacting with cryo-ET and subtomogram averaging data.
https://brisvag.github.io/blik/
GNU General Public License v3.0
23 stars 8 forks source link

Improve io #101

Closed brisvag closed 3 years ago

brisvag commented 3 years ago

This changed lazy_loader from a function that returns data, to a function that accepts a datablocks and updates it as it pleases.

This makes it possible to have more complex behaviour and avoid having to set some thing at datablock creation. Specifically, it removes the necessity to set pixel_size from mrc headers on instantiation. This significanlty speeds up loading time over slow network connections (from a minute to a 3-4 secibds, with ~150 images).

codecov[bot] commented 3 years ago

Codecov Report

Merging #101 (95027e0) into develop (b09f484) will decrease coverage by 0.03%. The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
- Coverage    83.22%   83.19%   -0.04%     
===========================================
  Files           92       92              
  Lines         2087     2089       +2     
===========================================
+ Hits          1737     1738       +1     
- Misses         350      351       +1     
Impacted Files Coverage Δ
peepingtom/__main__.py 83.87% <50.00%> (-2.34%) :arrow_down:
peepingtom/io_/reading/mrc.py 90.00% <85.71%> (ø)
...eepingtom/datablocks/abstractblocks/simpleblock.py 75.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c2bb67...95027e0. Read the comment docs.