brisvag / blik

Python tool for visualising and interacting with cryo-ET and subtomogram averaging data.
https://brisvag.github.io/blik/
GNU General Public License v3.0
23 stars 8 forks source link

Make scaling more consistent #103

Closed brisvag closed 3 years ago

brisvag commented 3 years ago

Before, scaling based on pixel size was handled by napari. This resulted in inconsistent behaviour, because vector lengths and widths and point sizes were being scaled as well. This meant that particles coming from data at 10A/px would result in points and vectors half as big as particles coming from data at 5A/px.

By handling scaling on our side, we avoid this problem.

codecov[bot] commented 3 years ago

Codecov Report

Merging #103 (1b63ccb) into develop (229f706) will increase coverage by 0.13%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #103      +/-   ##
===========================================
+ Coverage    83.27%   83.41%   +0.13%     
===========================================
  Files           92       92              
  Lines         2075     2074       -1     
===========================================
+ Hits          1728     1730       +2     
+ Misses         347      344       -3     
Impacted Files Coverage Δ
...epingtom/datablocks/abstractblocks/spatialblock.py 96.66% <100.00%> (+10.95%) :arrow_up:
peepingtom/depictors/napari/imagedepictor.py 100.00% <100.00%> (ø)
peepingtom/depictors/napari/naparidepictor.py 83.33% <100.00%> (-1.05%) :arrow_down:
peepingtom/depictors/napari/particledepictor.py 90.00% <100.00%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a02e5ec...1b63ccb. Read the comment docs.