search

brisvag / blik

Python tool for visualising and interacting with cryo-ET and subtomogram averaging data.
https://brisvag.github.io/blik/
GNU General Public License v3.0
23 stars 8 forks source link

sphereblock is now new-style multiblock #105

Closed brisvag closed 3 years ago

brisvag commented 3 years ago

Together with #98, addresses and closes #85.

codecov[bot] commented 3 years ago

Codecov Report

Merging #105 (5367bce) into develop (c6ad68e) will increase coverage by 0.65%. The diff coverage is 90.00%.

:exclamation: Current head 5367bce differs from pull request most recent head a5782cd. Consider uploading reports for the commit a5782cd to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #105      +/-   ##
===========================================
+ Coverage    83.88%   84.53%   +0.65%     
===========================================
  Files           92       93       +1     
  Lines         2103     2101       -2     
===========================================
+ Hits          1764     1776      +12     
+ Misses         339      325      -14
Impacted Files Coverage Δ
peepingtom/datablocks/__init__.py 100.00% <ø> (ø)
peepingtom/datablocks/simpleblocks/__init__.py 100.00% <ø> (ø)
...eepingtom/datablocks/simpleblocks/propertyblock.py 52.77% <60.00%> (-0.35%) :arrow_down:
peepingtom/datablocks/multiblocks/__init__.py 100.00% <100.00%> (ø)
.../datablocks/multiblocks/_tests/test_sphereblock.py 100.00% <100.00%> (ø)
peepingtom/datablocks/multiblocks/sphereblock.py 100.00% <100.00%> (ø)
...ngtom/datablocks/multiblocks/orientedpointblock.py 77.77% <0.00%> (-4.05%) :arrow_down:
peepingtom/datablocks/simpleblocks/pointblock.py 92.15% <0.00%> (-3.85%) :arrow_down:
peepingtom/datablocks/simpleblocks/imageblock.py 82.60% <0.00%> (-1.61%) :arrow_down:
peepingtom/depictors/napari/particledepictor.py 90.00% <0.00%> (-1.18%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ecbafa...a5782cd. Read the comment docs.

brisvag commented 3 years ago

I moved from a single sphere to many sphere, so the multiblock feels more appropriate. I'm not super happy about the propertyblock, but I'm not sure what else it should be. We could make up a new simpleblock of shape (N, 4) where the 4th value is the radius, but it seemes more appropriate to have points defined as points. After all, we do the same with dipoles!

alisterburt commented 3 years ago

Looks good!