Closed brisvag closed 2 years ago
Merging #125 (538e595) into main (094aa1b) will increase coverage by
8.81%
. The diff coverage is88.63%
.
@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 78.96% 87.77% +8.81%
==========================================
Files 92 8 -84
Lines 2101 180 -1921
==========================================
- Hits 1659 158 -1501
+ Misses 442 22 -420
Impacted Files | Coverage Δ | |
---|---|---|
blik/__init__.py | 50.00% <ø> (-16.67%) |
:arrow_down: |
blik/widgets/volume_selector.py | 59.09% <59.09%> (ø) |
|
blik/widgets/file_reader.py | 88.88% <88.88%> (ø) |
|
blik/widgets/filter.py | 94.11% <94.11%> (ø) |
|
blik/_tests/conftest.py | 100.00% <100.00%> (ø) |
|
blik/_tests/test_reader.py | 100.00% <100.00%> (ø) |
|
blik/_tests/test_widget.py | 100.00% <100.00%> (ø) |
|
blik/reader.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 094aa1b...538e595. Read the comment docs.
I think it's time to get this in :) @alisterburt any thoughts?
changelog looks good and I agree having a napari plugin will be really nice! I haven't pulled it down yet and will take a look later, interested to see how you're storing the data for volume selection and making it accessible in the plugin though!
Now that
npe2
and the napari hub are getting pretty good, it would be nice to at least haveblik
show up in the hub.This PR introduces some big infrastructural changes, migrating away from the clunky dataset + depictor model into a more native plugin system. Yippie!
I also take this chance to update all the testing and packaging stuff to better reflect napari plugins and napari itself. EDIT: moved it to #126 and merged separately.
Features in this PR:
naaf.read
into napari layers.TODO, maybe in a later PR: