Closed brisvag closed 3 years ago
Merging #65 (bb34142) into develop (2c1d7ed) will increase coverage by
13.77%
. The diff coverage is91.07%
.
@@ Coverage Diff @@
## develop #65 +/- ##
============================================
+ Coverage 54.74% 68.51% +13.77%
============================================
Files 58 85 +27
Lines 1233 1639 +406
============================================
+ Hits 675 1123 +448
+ Misses 558 516 -42
Impacted Files | Coverage Δ | |
---|---|---|
...pingtom/core/datablocks/_tests/test_dipoleblock.py | 100.00% <ø> (ø) |
|
...epingtom/core/datablocks/_tests/test_imageblock.py | 100.00% <ø> (ø) |
|
...eepingtom/core/datablocks/_tests/test_lineblock.py | 100.00% <ø> (ø) |
|
...eepingtom/core/datablocks/_tests/test_meshblock.py | 100.00% <ø> (ø) |
|
...om/core/datablocks/_tests/test_orientationblock.py | 100.00% <ø> (ø) |
|
...ngtom/core/datablocks/_tests/test_particleblock.py | 100.00% <ø> (ø) |
|
...epingtom/core/datablocks/_tests/test_pointblock.py | 100.00% <ø> (ø) |
|
peepingtom/core/datablocks/orientationblock.py | 70.90% <ø> (+3.63%) |
:arrow_up: |
peepingtom/entry_points/peep.py | 0.00% <0.00%> (ø) |
|
peepingtom/analysis/particles.py | 88.88% <66.66%> (ø) |
|
... and 59 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7ce49e0...af514c2. Read the comment docs.
I added a tiny bit more info in docstrings.
Yes, all the shenanigans you mentioned work just fine, because we have a very solid base SimpleBlock
class that takes care of that :D
perfecto, let's go!!
Simple change that makes
PropertyBlock
more specific (now a dataframe) and introduces a metadata dict forParticleBlock
s.