brisvag / blik

Python tool for visualising and interacting with cryo-ET and subtomogram averaging data.
https://brisvag.github.io/blik/
GNU General Public License v3.0
23 stars 8 forks source link

[WIP] Cleaning up old code, getting ready for realease #76

Closed brisvag closed 3 years ago

brisvag commented 3 years ago

I think we're approaching the point of releasing a version that does the same stuff as last time, but better. With this in mind, I cleaned up some old code and improved the interface to some stuff.

I changed from click to argparse to remove a dependency, but most importantly because I wanted more control over the help message and a few other things that click made clunky.

There's still some work to do, this is a WIP!

codecov[bot] commented 3 years ago

Codecov Report

Merging #76 (8a149f4) into develop (0b7ad16) will increase coverage by 9.81%. The diff coverage is 83.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #76      +/-   ##
===========================================
+ Coverage    70.03%   79.84%   +9.81%     
===========================================
  Files           99       98       -1     
  Lines         1959     1945      -14     
===========================================
+ Hits          1372     1553     +181     
+ Misses         587      392     -195     
Impacted Files Coverage Δ
peepingtom/alchemists/from_points.py 100.00% <ø> (ø)
...tablocks/simpleblocks/_tests/test_propertyblock.py 100.00% <ø> (ø)
peepingtom/io_/utils/generic.py 100.00% <ø> (ø)
peepingtom/io_/write/write.py 25.00% <ø> (ø)
peepingtom/utils/colors.py 100.00% <ø> (ø)
peepingtom/utils/dispatchlist.py 56.55% <ø> (+10.65%) :arrow_up:
peepingtom/peeper.py 70.35% <48.00%> (ø)
peepingtom/__main__.py 54.54% <54.54%> (+54.54%) :arrow_up:
peepingtom/depictors/napari/particledepictor.py 85.71% <75.00%> (-4.92%) :arrow_down:
peepingtom/io_/read/read.py 63.29% <85.71%> (+44.99%) :arrow_up:
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36b8b76...8a149f4. Read the comment docs.

alisterburt commented 3 years ago

Ah okay, cool! If it’s just from the command line then I think using a glob pattern is probably something more people are at ease with then? regex is definitely more powerful but I think it’s rare you’d need that power in this case

On 9 Mar 2021, at 22:37, Lorenzo Gaifas notifications@github.com wrote:

 @brisvag commented on this pull request.

In peepingtom/io_/read/read.py:

- -def read(paths, mode=None, **kwargs):

  • """
  • read generic path(s) and construct a dataset accordingly
  • mode:
  • filters: a regex string or iterable thereof used to select filenames [default: '.*'] This is not something that can be passed from command line though. We can make it possible from pt.read, but not here!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

alisterburt commented 3 years ago

Sounds good!

brisvag commented 3 years ago

Closes #70 and #41.