britalmeida / push_to_talk

Add-on for recording audio in Blender's Sequencer
GNU General Public License v3.0
49 stars 11 forks source link

fix windows and ffmpeg(latest) #15

Closed notwarp closed 1 year ago

britalmeida commented 1 year ago

@notwarp hello! Thank you very much for the pull request.

First of all, my apologies, I missed the notification for this PR and it's been waiting for months 😭. Very sorry about that!

Onto the actual thing... could you say what is this fixing and why?

britalmeida commented 1 year ago

After testing the support on Windows I think I understand what it was about. It seems that dshow list_devices can have 2 output formats, and this PR made it work when it would output entries tagged (audio) in addition to the previous? grouped output. I couldn't easily find information on when the output style changed.

I've included this fix in the commit above (but didn't merge it directly as I made significant changes). Thank you!