britannio / in_app_review

A Flutter plugin for showing the In-App Review/System Rating pop up on Android, IOS, and MacOS. It makes it easy for users to rate your app.
327 stars 82 forks source link

InAppReviewPlugin.java uses or overrides a deprecated API. #113

Closed AmineMessabhia closed 8 months ago

AmineMessabhia commented 9 months ago

Hello,

So your package was -and still is- working fine, but I faced this while building:

Note: C:\Users\Amine\AppData\Local\Pub\Cache\hosted\pub.dev\in_app_review-2.0.8\android\src\main\java\dev\britannio\in_app_review\InAppReviewPlugin.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details.

I thought you might want to hear about this, and maybe fix it or something, it ain't critical now, but it might become so in the future.

Thank you for the package and for your hard work!

Joldersman commented 9 months ago

Confirm. The same problem.

Note: /hosted/pub.dev/in_app_review-2.0.8/android/src/main/java/dev/britannio/in_app_review/InAppReviewPlugin.java uses or overrides a deprecated API. Note: Recompile with -Xlint:deprecation for details. /android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java:19: error: cannot find symbol flutterEngine.getPlugins().add(new dev.fluttercommunity.plus.device_info.DeviceInfoPlusPlugin()); ^ symbol: class DeviceInfoPlusPlugin location: package dev.fluttercommunity.plus.device_info

android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java:49: error: cannot find symbol flutterEngine.getPlugins().add(new dev.fluttercommunity.plus.packageinfo.PackageInfoPlugin()); ^ symbol: class PackageInfoPlugin location: package dev.fluttercommunity.plus.packageinfo 2 errors

FAILURE: Build failed with an exception.

AmineMessabhia commented 9 months ago

@britannio check this whenever possible, please ^_^

Wendler commented 9 months ago

@AmineMessabhia Check if #112 solves the problem

lucaesposto commented 8 months ago

Same problem over here. Has #112 been published? https://pub.dev/packages/in_app_review -> still 2.0.8 (Published 5 months ago)

britannio commented 8 months ago

2.0.9 has been published, thanks for your patience.