search

britannio / in_app_review

A Flutter plugin for showing the In-App Review/System Rating pop up on Android, IOS, and MacOS. It makes it easy for users to rate your app.
289 stars 75 forks source link

Update Play Core Maven dependency to an Android 14 compatible version #126

Open faaqi opened 2 weeks ago

faaqi commented 2 weeks ago

We received this mail from Google regarding the Play Core library issue and as we're not using the Core library in our project , we found that it is being used as transitive dependency from this In app review package.

com.google.android.play:core has added this note for core:1.10.3:

Update your Play Core Maven dependency to an Android 14 compatible version! Your current Play Core library is incompatible with targetSdkVersion 34 (Android 14), which introduces a backwards-incompatible change to broadcast receivers to improve user security. As a reminder, from August 31, Google Play requires all new app releases to target Android 14. Update to the latest Play Core library version dependency to avoid app crashes: https://developer.android.com/guide/playcore#playcore-migration

You may not be able to release future versions of your app with this SDK version to production or open testing.

When will be the next update of this package to resolve this issue?

Here are logs:

image
britannio commented 2 weeks ago

Looks similar to https://github.com/britannio/in_app_review/issues/125 which was fixed two years ago.

britannio commented 2 weeks ago

Which version of the package are you using?

faaqi commented 2 weeks ago

We're using 2.0.4. Thanks, I'll update the package

craigomac commented 2 weeks ago

This doesn't appear to be fixed.

By running ./gradlew app:dependencies > dependencies.txt and checking dependencies.txt:

+--- project :in_app_review
|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
|    +--- com.google.android.play:review:2.0.1
|    |    +--- com.google.android.gms:play-services-basement:18.1.0 (*)
|    |    +--- com.google.android.gms:play-services-tasks:18.0.2 (*)
|    |    \--- com.google.android.play:core-common:2.0.2
craigomac commented 2 weeks ago 
|    |    \--- com.google.android.play:core-common:2.0.2

Ah, perhaps I misunderstood. core-common is one of the split libraries, not the previous monolithic core library?

britannio commented 1 week ago

The latest version of the API is https://developer.android.com/reference/com/google/android/play/core/release-notes-in_app_reviews which this package is using.

https://github.com/britannio/in_app_review/blob/master/in_app_review/android/build.gradle#L53