search

britannio / in_app_review

A Flutter plugin for showing the In-App Review/System Rating pop up on Android, IOS, and MacOS. It makes it easy for users to rate your app.
327 stars 82 forks source link

freezes app on iOS 18 #147

Open lukepighetti opened 4 days ago

lukepighetti commented 4 days ago

it appears that in_app_review 2.0.10 (and before) freezes any iOS 18 app when calling InAppReview.instance.requestReview(). only tested on simulator (18.1)

britannio commented 4 days ago

it appears that in_app_review 2.0.10 (and before) freezes any iOS 18 app when calling InAppReview.instance.requestReview(). only tested on simulator (18.1)

Thanks for filing an issue. I didn't have any luck reproducing this with a fresh Flutter app on the simulator (18.1 too). Do you have any guidance for reproducing it? I used flutter create then flutter pub add in_app_review then added the following code to the counter app:

const CircularProgressIndicator(),
const CircularProgressIndicator(),
const CircularProgressIndicator(),
ElevatedButton(
  onPressed: () {
    InAppReview.instance.requestReview();
  },
  child: const Text('Request Review'),
)

A video would be better but the spinners do keep spinning.

woelmer commented 4 days ago

It also froze for me on 18.1 simulator and I was on 2.0.9

lukepighetti commented 4 days ago

this might be related

https://github.com/britannio/in_app_review/issues/136

britannio commented 4 days ago

I can occasionally reproduce this on the simulator by disabling wifi on my mac but it's difficult to pinpoint the cause of this. It also fixes itself after 8 seconds. It's possible that the StoreKit requestReview() method is blocking the main thread due to a timeout of some sort.

image

britannio commented 4 days ago

To clarify, does the pop-up appear when the freeze occurs?

lukepighetti commented 4 days ago

The pop up does not appear when the freeze occcurs