search

britannio / in_app_review

A Flutter plugin for showing the In-App Review/System Rating pop up on Android, IOS, and MacOS. It makes it easy for users to rate your app.
311 stars 81 forks source link

iOS SKStoreReviewController.requestReview(in: scene) Issue #25

Closed SwedenJohansson closed 3 years ago

SwedenJohansson commented 3 years ago

Encountered an issue in when building for iOS: SKStoreReviewController.requestReview(in: scene)

Error message:

    /Users/XXXXX/.pub-cache/hosted/pub.dartlang.org/in_app_review-2.0.1/ios/Classes/SwiftInAppReviewPlugin.swift:26:63: error: argument passed to call that takes no arguments
                        SKStoreReviewController.requestReview(in: scene)
                                                                  ^~~~~

My solution was to manually go into /Users/XXXXX/.pub-cache/hosted/pub.dartlang.org/in_app_review-2.0.1/ios/Classes/ and edit the file and remove "in: scene".

I have target delopyment set to 10.3.

Is there a better work around for this?

britannio commented 3 years ago

@SwedenJohansson Which version of XCode are you using? This should work without any issues.

You can even checkout the IOS build of the example app via https://pub.green/packages/in_app_review

paulononaka commented 3 years ago

Same thing happening to me. XCode 11.7 and I also did set target to 10.3.

britannio commented 3 years ago

@paulononaka Can you upgrade to XCode 12?

britannio commented 3 years ago

@SwedenJohansson @paulononaka Can either of you confirm that upgrading to XCode 12 fixed the issue?

paulononaka commented 3 years ago

Hi @britannio looks like it is working fine on XCode 12. Thank you very much.