search

britannio / in_app_review

A Flutter plugin for showing the In-App Review/System Rating pop up on Android, IOS, and MacOS. It makes it easy for users to rate your app.
306 stars 78 forks source link

Maintenance #72

Closed britannio closed 1 year ago

britannio commented 1 year ago

Closes https://github.com/britannio/in_app_review/issues/58 Closes https://github.com/britannio/in_app_review/issues/71

davidmartos96 commented 1 year ago

Java dependency com.google.android.play:review has been updated to 2.0.1

@britannio Is there any update on this? In-app review was not working on my Android device in the internal track, whereas using this PR did.

britannio commented 1 year ago

Java dependency com.google.android.play:review has been updated to 2.0.1

@britannio Is there any update on this? In-app review was not working on my Android device in the internal track, whereas using this PR did.

Gotcha, I'll get this published by the end of the week, possibly today.

davidmartos96 commented 1 year ago

@britannio Great! It's possible that #68 gets resolved. Maybe proguard was necessary with the old Play Core package, but now there is a specific dependency for in app review on Android.

Oleksandr32 commented 1 year ago

hi @britannio, sorry for annoying Nothing changed, do you still plan to publish the new version this week?

alan2030 commented 1 year ago

@britannio Great! It's possible that #68 gets resolved. Maybe proguard was necessary with the old Play Core package, but now there is a specific dependency for in app review on Android.

Not sure if this is the right place, but I am on Flutter 1.22. I think I won't be able to upgrade the library because of that. Do you mind sharing what has been added to fix the issue, so that I can manually implement myself? Also thinking calling in-app-review from Java/Kotlin if this doesn't work out.

Thank you!

davidmartos96 commented 1 year ago

@alan2030 You can try changing the Android dependency in tje gradle file to the new one to see if that was the cause. Before the com.google.android.play:core dependency was used. Now there is one specific for the in app reviews com.google.android.play:review

alan2030 commented 1 year ago

fore the com.google.android.play:core dependency was used. Now there is one specific for the in app reviews com.google.android.play:review

@davidmartos96 Thank you for you reply!

I have 2 build.gradle files and it seems that none of them have com.google.android.play:core or com.google.android.play:review

Which one I should add it to? The one in "android" folder or "app" folder? Its weirds that app review is working on some devices considering project is missing those dependencies.

davidmartos96 commented 1 year ago

@alan2030 The file is in_app_review/android/build.gradle

And the line is implementation 'com.google.android.play:core:1.10.0'

davidmartos96 commented 1 year ago

@britannio Hello! Did something break with the PR? Or are you still planning to merge and update soon?

britannio commented 1 year ago

@britannio Great! It's possible that #68 gets resolved. Maybe proguard was necessary with the old Play Core package, but now there is a specific dependency for in app review on Android.

Not sure if this is the right place, but I am on Flutter 1.22. I think I won't be able to upgrade the library because of that. Do you mind sharing what has been added to fix the issue, so that I can manually implement myself? Also thinking calling in-app-review from Java/Kotlin if this doesn't work out.

Thank you!

Any particular reason for being on such an old version?

britannio commented 1 year ago

@britannio Hello! Did something break with the PR? Or are you still planning to merge and update soon?

Sincere apologies for the delay, it has been merged and published.

davidmartos96 commented 1 year ago

@britannio Hello! Did something break with the PR? Or are you still planning to merge and update soon?

Sincere apologies for the delay, it has been merged and published.

No worries, thanks for the update!