search

britannio / in_app_review

A Flutter plugin for showing the In-App Review/System Rating pop up on Android, IOS, and MacOS. It makes it easy for users to rate your app.
327 stars 82 forks source link

Adds Android namespace #89

Closed asaarnak closed 1 year ago

asaarnak commented 1 year ago

Adds a namespace attribute to the Android build.gradle, for compatibility with Android Gradle Plugin 8.0. See: https://github.com/flutter/packages/commit/6284c2d4e46a5d289e77cb03a9457543b97f750b

cuong0993 commented 1 year ago

Can we merge this change and release an update?

britannio commented 1 year ago

Can we merge this change and release an update?

I'll need to test it out, what's the significance of the change? Is anything broken?

cuong0993 commented 1 year ago

It will fix the build if using AGP 8. Build error can be found here https://github.com/cuong0993/issue/blob/master/pubspec.yaml#L39 image

Some popular packages already did it. https://github.com/firebase/flutterfire/commit/a3b967354294c295a9be8d699a6adb7f4b1dba7f https://github.com/fluttercommunity/plus_plugins/commit/4faa5d8a9c5d3ebbfe16ce30d3a54d25c84b208a

asaarnak commented 1 year ago

Can we merge this change and release an update?

I'll need to test it out, what's the significance of the change? Is anything broken?

Shouldn't break anything, just adds AGP 8 support.

under3415 commented 1 year ago

I was able to build the project with Gradle 8 after referring to this fork in pubspec.yaml:

in_app_review: 
    git: 
      url: https://github.com/asaarnak/in_app_review.git
      ref: patch-1
      path: in_app_review
davidmartos96 commented 1 year ago

@britannio Any chance to publish a https://pub.dev version with this?

AndreaMinato commented 1 year ago

@britannio Can confirm it builds no problem with this changes

NachiketaVadera commented 1 year ago

hey @britannio

any plans to release this update?

britannio commented 1 year ago

Thanks for the contribution, this will be published shortly!

tushar0518 commented 1 year ago

any update for releasing the new version? @britannio

britannio commented 1 year ago

any update for releasing the new version? @britannio

Yeah, my laptop is in repair until ~Thursday. You can depend on the latest git version until then and I'll leave a comment when the release is out.

absar commented 1 year ago

It needs to be released soon, since most of the plugins are upgraded to AGP 8, this plugin is preventing Apps from upgrading