britiger / bikeparkingberlin

https://bikeparking.lorenz.lu/
3 stars 4 forks source link

Retry Maproulette GeoJSON #44

Closed tordans closed 4 years ago

tordans commented 4 years ago

This might solve the Maproulette Problem from https://github.com/britiger/bikeparkingberlin/issues/24#issuecomment-543953182. I followed nrotstan's recommendations from https://github.com/osmlab/maproulette3/issues/952#issuecomment-583753724 and added the uuid as geojson-id on every entry. Our identifiers are moved to externalId – which we might need to remove as well, should they be to similar to OSM IDs.

britiger commented 4 years ago

Fixed and published to bikeparkiing.lorenz.lu . But I don't have time to check it on maproulette now.

tordans commented 4 years ago

@britiger the resulting json https://bikeparking.lorenz.lu/geojson/missing/Berlin%20Neuk%C3%B6lln does not show the @id-field which is supposed to hold the uuid.

https://github.com/britiger/bikeparkingberlin/commit/46be389a45de7f1b4109f75fc1681fdacba3710f#diff-8786d2a661e5179156e0607f88919097R163-R164

I am not familiar with the code enough; is the uuid something that should be there for every database entry?