search

britkat1980 / giv_tcp

TCP connection (from inverter) and MQTT implementation
78 stars 37 forks source link

Terminology inconsistency between set and confirm messages - GivTCP v2.3.3 #114

Closed Yorkie71 closed 1 day ago

Yorkie71 commented 1 year ago

A minor issue but I have noticed an inconsistency between the set and confirmation logs when I configure the Battery Reserve % setting. It's not a huge issue but it did create some minor confusion when I was checking if a recent automation change had worked and initially thought that another setting had been changed from the one I intended.

2023-09-11 00:33:56,199 - Inv1 - write - [INFO ] - Setting battery reserve target to: 100 2023-09-11 00:33:58,394 - Inv1 - write - [INFO ] - Setting shallow charge 100 was a success 2023-09-11 00:47:39,947 - Inv1 - write - [INFO ] - Setting battery reserve target to: 4 2023-09-11 00:47:44,194 - Inv1 - write - [INFO ] - Setting shallow charge 4 was a success 2023-09-11 01:33:24,089 - Inv1 - write - [INFO ] - Setting battery reserve target to: 100 2023-09-11 01:33:26,297 - Inv1 - write - [INFO ] - Setting shallow charge 100 was a success