Just noticed this while browsing the code... if you set any one slot to 100%, it looks like this will disable the charge target. Does that turn it off for all charging slots? If not, should only clear it if it's the correct slot.
Is there any reason to clear it when the target is 100% ? Does it go wrong if the limit is enabled but it's 100% anyway ?
https://github.com/britkat1980/giv_tcp/blob/dba5d03aff932f703853d834041bef73e4675634/givenergy_modbus/client.py#L138
Just noticed this while browsing the code... if you set any one slot to 100%, it looks like this will disable the charge target. Does that turn it off for all charging slots? If not, should only clear it if it's the correct slot.
Is there any reason to clear it when the target is 100% ? Does it go wrong if the limit is enabled but it's 100% anyway ?
Also, a few lines on, https://github.com/britkat1980/giv_tcp/blob/dba5d03aff932f703853d834041bef73e4675634/givenergy_modbus/client.py#L142 I think my gen-3 hybrid also needs to write to slot_1 rather than the the original slot. But I need to go back and check. (The app seems to set the wrong slot, and my overnight script just copies from the one the app writes to the one the inverter seems to use. But off-hand I can't remember which one was which now.)