Issue with 2.3.1

[ProximusAl]

Sorry if I'm not doing this correctly, never made a bug report on GitHub before.

Docker 2.3.0 works perfectly but since updating to 2.3.1 I now get this:

2023-07-31 07:35:35,694 - startup - [CRITICAL] - Recreating settings.py for invertor 1 Traceback (most recent call last): File "/app/startup.py", line 256, in {1: '192.168.76.138', 2: '192.168.76.150'} if SuperTimezone: outp.write(" timezone=\""+str(SuperTimezone)+"\"\n") NameError: name 'SuperTimezone' is not defined

Rolling back to 2.3.0 and I'm up and running again.

[CaptSB]

For me, 2.3.0 stopped working at approx 01:30 on 30 Jul. 2.3.1 has either not fixed the issue or made it worse.

[ProximusAl]

For me, 2.3.0 stopped working at approx 01:30 on 30 Jul. 2.3.1 has either not fixed the issue or made it worse.

Your issue may be this....different to mine:

New ENV/Config item Inverter_AC_X - Only turn this on if you have an AC inverter on "old" firmware and you get errors on startup

[CaptSB]

I have tried returning to 2.2.4 with some success - Most Entities returned to a working state.

2.3.1 simply doesn’t work with my setup and some entities in 2.2.4 seem not to work correctly either… I will carry on and see if I can understand what is happening.

On 31 Jul 2023, at 08:17, ProximusAl @.***> wrote:

For me, 2.3.0 stopped working at approx 01:30 on 30 Jul. 2.3.1 has either not fixed the issue or made it worse.

Your issue may be this....different to mine:

New ENV/Config item Inverter_AC_X - Only turn this on if you have an AC inverter on "old" firmware and you get errors on startup

— Reply to this email directly, view it on GitHub https://github.com/britkat1980/giv_tcp/issues/93#issuecomment-1657803744, or unsubscribe https://github.com/notifications/unsubscribe-auth/A64N7OV2YTJ245YIYJK5BILXS5LXZANCNFSM6AAAAAA25ZPVXM. You are receiving this because you commented.

[CaptSB]

The 2.2.4 issue was my mistake - I had incorrectly re-named an entity that is a Template sensor.

So… 2.2.4 is all working; 2.3.0 was working until 01:30 yesterday morning; 2.3.1 doesn’t work - all numerical entities are being reported as non-numeric (probably “Unknown”)

I have a Gen 1 Hybrid inverter with a single battery.

I am running the latest HA on a Raspberry Pi and using MQTT to connect to giv_tcp.

I will stick with 2.2.4 until I can be assured that a new version works without issue - happy to test things though if a “fixed” version is issued - Not an expert but I have generally good technical knowledge.

On 31 Jul 2023, at 08:17, ProximusAl @.***> wrote:

For me, 2.3.0 stopped working at approx 01:30 on 30 Jul. 2.3.1 has either not fixed the issue or made it worse.

Your issue may be this....different to mine:

New ENV/Config item Inverter_AC_X - Only turn this on if you have an AC inverter on "old" firmware and you get errors on startup

— Reply to this email directly, view it on GitHub https://github.com/britkat1980/giv_tcp/issues/93#issuecomment-1657803744, or unsubscribe https://github.com/notifications/unsubscribe-auth/A64N7OV2YTJ245YIYJK5BILXS5LXZANCNFSM6AAAAAA25ZPVXM. You are receiving this because you commented.

[CaptSB]

What a great dat for a GivEnergy Battery Firmware Update!!

On 31 Jul 2023, at 08:17, ProximusAl @.***> wrote:

For me, 2.3.0 stopped working at approx 01:30 on 30 Jul. 2.3.1 has either not fixed the issue or made it worse.

Your issue may be this....different to mine:

New ENV/Config item Inverter_AC_X - Only turn this on if you have an AC inverter on "old" firmware and you get errors on startup

— Reply to this email directly, view it on GitHub https://github.com/britkat1980/giv_tcp/issues/93#issuecomment-1657803744, or unsubscribe https://github.com/notifications/unsubscribe-auth/A64N7OV2YTJ245YIYJK5BILXS5LXZANCNFSM6AAAAAA25ZPVXM. You are receiving this because you commented.

[ProximusAl]

So the issue as far as I can see is this line:

if SuperTimezone: outp.write(" timezone=\""+str(SuperTimezone)+"\"\n")

This doesn't take into account if IsAddon being false therefore crapping out because SuperTimeZone is only ever defined when True.

I don't know how to do pull requests but I'm sure this would fix it:

if isAddon: if SuperTimezone: outp.write(" timezone=\""+str(SuperTimezone)+"\"\n") else:

[78davidcross]

I am also receiving the "NameError: name 'SuperTimezone' is not defined" error when trying to start 2.3.1.

I have single Hybrid Inverter running firmware 909, single battery. I run GivTCP on a Synology in Docker using the giv_tcp-ma "latest" image which means currently I can't "downgrade" without more involved work to duplicate the existing container into a "new" one that would use the 2.2.4 image that I had before and so I don't have a working GivTCP system as it stands.

I have added "Inverter_AIO_X" as an ENV variable and set it to "False" and tried it on True but the same error occurs.

I think there's confusion over this variable name as well. I think Docker has created\added "INVERTOR_AIO_1", "INVERTOR_AC_1" with "2" and "3" copies as well and set them all to False. To me, if this variable relates to firmware then should the term "firmware old" appear in the variable name?

[78davidcross]

To confirm, version 2.3.2 has now resolved this for me, thanks.

[ProximusAl]

And for me. Thanks.

Will close the issue.

[CaptSB]

Sorry for my earlier rants. I seem to have fixed it now. Simple typo in my reinstalled config in the end but the issues just build up and I started to panic!

Keep up the great work!

On Mon, 31 Jul 2023 at 21:36, ProximusAl @.***> wrote:

Closed #93 https://github.com/britkat1980/giv_tcp/issues/93 as completed.

— Reply to this email directly, view it on GitHub https://github.com/britkat1980/giv_tcp/issues/93#event-9968723080, or unsubscribe https://github.com/notifications/unsubscribe-auth/A64N7OSA5ZMHLEG4APTGX5DXTAJMFANCNFSM6AAAAAA25ZPVXM . You are receiving this because you commented.Message ID: @.***>

-- Sent from Gmail Mobile