Closed brettdh closed 6 years ago
The biggest thing I'm unsure about right now is all the memoryview(bytearray)
stuff, as I haven't worked with that before. I intend to familiarize myself more thoroughly and revisit all the hacky things I did to make it work, especially to understand the performance implications. (A performance test probably wouldn't be out of place either.)
Have merged this into develop, and will close this PR I get the 3.x tests passing (see develop-merge-27 branch, which will merge back to master).
I'll place a note in README.md that this should work on 2.7, but I won't commit to 2.7 compatibility on future commits to master, more or less for philosophical reasons.
Merged to master. However, while tests pass on 3.3 and 3.4, 2.7 doesn't seem to work well at all after my merge:
https://travis-ci.org/britram/python-ipfix/jobs/277778480
Will need to investigate this before releasing 0.9.8 (as I really would like to have things running on 2.7 before doing the release)... but am out of cycles on this again for a couple weeks.
All tests and doctests now pass for me under Python 2.7.8 and 3.4.1. (38b8d73 fixes a bunch of Python 3 regressions.)
Sorry for all the whitespace changes (automatic, courtesy of Atom); somehow I thought Github could hide them when reviewing a pull request.