search

brittanyarima / Steps

Open Source Step Counting App using HealthKit & SwiftUI
MIT License
81 stars 32 forks source link

Add New tab with week/month step data using SwiftCharts #30

Closed brittanyarima closed 1 year ago

brittanyarima commented 1 year ago
WasifRaza123 commented 1 year ago

Hey @brittanyarima , I want to work on this.

brittanyarima commented 1 year ago

@WasifRaza123, Great! You got it!

WasifRaza123 commented 1 year ago

Hey @brittanyarima , I have some questions regarding the TabView.

  1. Will this be a new tab in the tab bar?
  2. Are there any reference for the UI design or is it complete based on my personal vision?
brittanyarima commented 1 year ago

@WasifRaza123 Yes, this should be a new tab in the tab bar with a reasonable icon and name I absolutely love what SwiftUI charts is capable of & just think utilizing them could be really cool! some examples: https://github.com/jordibruin/Swift-Charts-Examples/tree/main

The app is using mostly native swiftUI design things, so I say stay in that realm but I'm good with whatever UI ideas you have! Just mainly getting at least one chart built using their weekly step data. Even with mock data to start and I can update it with the real HealthKit data.

brittanyarima commented 1 year ago

Hope that makes sense! Feel free to ask any questions if not!

WasifRaza123 commented 1 year ago

Hey @brittanyarima , I have created a basic Week chart. How to improve this like what else I can add or edit?

Screenshot 2023-10-03 at 10 10 38 PM
brittanyarima commented 1 year ago

Wow! That looks great!! @WasifRaza123 If you wanted to fill up the screen a bit more, you could add a list or something below with some fun facts like "Number of times: Reached goal this week - with the number next to it. & Highest number of steps - with the number. Honestly this looks great tho! If you want to stop here, that's fine too & I can make another issue to have someone fill up the screen. If you want to keep working on it, that's great too!

One thing I'd say is maybe to move the Steps tab to the left of Settings? So the Settings Tab is on the far right.

WasifRaza123 commented 1 year ago

I have completed this @brittanyarima . I am also working on some other tasks due to which I was unable to properly design a view for the empty space below the weekly chart. This is my first open source contribution so there might be a lot of mistakes. Pr Link: https://github.com/brittanyarima/Steps/pull/40

brittanyarima commented 1 year ago

@WasifRaza123 this is great! This is so incredibly helpful for getting this tab started. Thanks so much for contributing!