search

brittanyblouin / ANCRTAdjust

An R package to adjust routine HIV testing data from antenatal care to reduce bias in estimating HIV prevalence trends
MIT License
2 stars 3 forks source link

descriptive_plot axis limits #19

Closed seabbs closed 4 years ago

seabbs commented 5 years ago

Do these need to be manually specified?

The current default shows the complete percentage range which in most circumstances is not going to be ideal when trying to understand trends over time (which is my interpretation of what this function is doing).

My preference would be to have no specified range and rely on ggplot2 defaults. User can then add limits as required.

What are your thoughts on this?

For this # openjournals/joss-reviews/issues/1740 review

m-maheu-giroux commented 4 years ago

We also initially wondered if it would be best to just use the default but decided against this. The issue being that prevalence and testing coverage could potentially exhibit important variations over time and across facilities. Comparing them using standardized default values makes more sense.

seabbs commented 4 years ago

Okay - happy to go with you on this.

However, it can be difficult to see both trends over time and differences between groups if the groups are on very difficult scales. The current plot obscures trends if there are large differences. Might want to discuss this a little in the docs or provide a standardised option (for trends vs. differences).

m-maheu-giroux commented 4 years ago

Fair point. I have implemented your requested changes and switched to default. Users still have the option of using their own supplied limits for the y-axis

seabbs commented 4 years ago

Okay great - thanks!

(looks like the README needs updating)