`improv_adjust` combining two functions into one.

brittanyblouin / ANCRTAdjust

An R package to adjust routine HIV testing data from antenatal care to reduce bias in estimating HIV prevalence trends

MIT License

2 stars 3 forks source link

`improv_adjust` combining two functions into one. #23

Closed seabbs closed 4 years ago

seabbs commented 5 years ago

I see improv_adjust and improv_adjust_simple - can these functions be combined?

If not why not?

Overall I think some more detail on the differences between these two would be good.

m-maheu-giroux commented 4 years ago

The two functions have been combined. There is no major differences between the two functions... simply that one uses point estimates for HIV prevalence and HIV testing coverage whereas the other one uses a data frame as input.

seabbs commented 4 years ago

Great - thanks (I see some good changes to function arguments as well 👍 ).

Could you link to changes (i.e the commit or pull request) in the review issues - really helps me keep track of what is happening!

seabbs commented 4 years ago

Nice thanks