Fixed typos + Enhanced ReadMe

krupalitrivedi commented 2 years ago

The following PR makes changes in the ReadMe file of the repository. The steps written for producing the repository on local machine has been made better. This will help in better understanding of the steps.

Link to issue this resolves - #17

Fixes #17

[x] The title should be something descriptive about what you change to do. (It will default to whatever you put as your commit message.)

This description should include :

[x] A short summary of your changes
[x] A link to the issue that relates to these changes
[x] A screenshot of the changes if possible!

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @brittanyjoiner15 on Vercel.

@brittanyjoiner15 first needs to authorize it.

krupalitrivedi commented 2 years ago

Some small changes requested, shouldn't take too long. Also can you make sure you've got the most recent version of main? It looks like your readme file is missing some information that thas been added

Alright, I will work on it and make sure to update my PR in minimum time.

brittanyjoiner15 commented 2 years ago

@krupalitrivedi great, thank you!

krupalitrivedi commented 2 years ago

Most of the changes are done from my side, I have to update about the Speakers Tab, I have commented with a question for the same, as soon I finish doing that, the changes will be done :)

brittanyjoiner15 commented 2 years ago

@krupalitrivedi very close! Can you resolve the merge conflicts and address the two things i left comments on? Then I think we're good to merge this! Thanks for your work on it!

brittanyjoiner15 commented 2 years ago

@krupalitrivedi did you get a chance to resolve the merge conflicts and fix the couple comments I had? Would love to merge this soon as it's so close! Let me know if you need any help

krupalitrivedi commented 1 year ago

Oh I did get chance to fix it! I am unsure on how exactly i fix the merge conflicts, if you can help with that :) do i just push the changes i made on local computer?

brittanyjoiner15 commented 1 year ago

@krupalitrivedi yes push your changes from your local computer and then I'll take a look at the merge conflicts!

brittanyjoiner15 commented 1 year ago

@krupalitrivedi hey there! have you had a chance to push those changes? Happy to help with the merge conflicts but want to make sure I've got everything from your local machine first!

krupalitrivedi commented 1 year ago

@krupalitrivedi hey there! have you had a chance to push those changes? Happy to help with the merge conflicts but want to make sure I've got everything from your local machine first!

Yes! I actually did make the changes you mentioned in last pushed files :) let me know if there are any other changes to be made

brittanyjoiner15 commented 1 year ago

@krupalitrivedi in the future, please tag maintainers or those who requested to changes to let them know you've made changes and when you're ready to review. I've sorted out the changes and cleaned up merge conflicts and I'll go ahead and approve and merge now.

krupalitrivedi commented 1 year ago

@brittanyjoiner15 thank you for teaching me so much during the whole interaction. You've been so patient and helpful. Thank you ✨

brittanyjoiner15 commented 1 year ago

@krupalitrivedi glad to help! welcome to the wonderful world of open source!

brittanyjoiner15 / eui-event-template