Open bpvcode opened 2 years ago
Someone is attempting to deploy a commit to a Personal Account owned by @brittanyjoiner15 on Vercel.
@brittanyjoiner15 first needs to authorize it.
Hello @brittanyjoiner15 ,
Hope everything is great with you.
In order to have a github-actions bot that writes the report on accessibility, performance, ... for each PR, you need to change the permissions of GITHUB_TOKEN
for read and write permissions for this repo.
You can do this by going to your repository or organization Settings
, then clicking on Actions
. You will see something like this:
This GITHUB_TOKEN
is the best way to use tokens with permissions in actions, rather than creating a PERSONAL_ACCESS_TOKEN
. You can find more info on the topic here.
I already tested the implementation of the jobs that I created and works on my personal repo, once I have that setting, but i can't do it in your repo.
Please see the result of what I want to implement:
You can even see a full report on the website here
When you make that change, we just need to run the job again, and a full report will be posted on this PR.
Hope to hear from you soon,
Thank you :)
@bpvcode confirming i've seen your comment and will take a look at this on Friday!
@bpvcode update... this is friday and the day got away from me and i haven't taken a look yet. so sorry - will try my best to this weekend! I am sure it's good to go and i just need to set up those things that you mentioned and can merge
Hello @brittanyjoiner15 how is this going? Do you need any further explanation from my side? :)
Happy coding!! ;)
@bpvcode didn't get a chance this weekend, and wont today if im being honest. I will shoot for tomorrow! Specifically adding this to my to do list to review! So sorry for the delay
No problem, take your time :)
@bpvcode so this is what it looks like in this repo's settings, which matches what you have in the screenshot. Do I need to change something here?
I like the way that looks and the report! Is there any way to show what the scores were BEFORE this PR? Ie, did they go up or down in sections based on a PRs requested changes?
@bpvcode heya! just checking to see if you can clarify what changes i still need to make here?
hey @bpvcode let me know if there's anything else i need to do here. otherwise, i'll close this out.
Describe your changes
Link to issue this resolves - #110