search

brittanyjoiner15 / eui-event-template

https://eui-event.vercel.app/
22 stars 45 forks source link

Minor UI fixes #121

Closed adsingh14 closed 1 year ago

adsingh14 commented 1 year ago

On both live/local website:

  1. Logo changes on switching theme

image image

  1. Full width container for navbar will look better image

On local server:

  1. <svg> icons are not visible.

image image

  1. Button flicker on toggle

https://user-images.githubusercontent.com/35252877/198667609-e881a25b-0fe8-405a-abd4-7dada2f070e2.mp4

I will contribute after discussion and getting assigned.

brittanyjoiner15 commented 1 year ago

@adsingh14 i would love if you can fix these! Those are all great points, here are some additional details for you that may help.

  1. I am not too worried about this one, i know it's a different logo, but it's pretty subtle so im okay with it! But if you want to propose a light and dark version that is fine with me!
  2. Agree on the full width navbar - that would be great, especially since our footer is full width
  3. on the local server - the reason that the icons aren't showing is a very strange bug that was introduced in Eui with the version i started with, and it's since been fixed but i havent' upgraded Eui. I have another issue out to do that, but it will probably be quite a bit of work. Feel free to skip over this one, if you'd like, or if you do want to do this, I can assign you that issue and you can do it in a separate PR!
  4. The button flicker - i would LOVE if you can fix this! I thought we had it fixed before, but i think it might have jumped back in at some point.
adsingh14 commented 1 year ago

Fourth point occurs only on local server, maybe that's connected with third point. Both 3rd and 4th points are working on live website.

I'm figuring the structure and CSS. The first one is optional; my priority is only the second point. FAQs and Home page content is in container unlike the rest of three pages. Any thoughts on this ?

brittanyjoiner15 commented 1 year ago

@adsingh14 ah right if it's only on local server, then yes it might have something to do with the 3rd point.

agree on priority is the second point, and first point is optional!

As far as FAQs and Home page - that's a good catch. Maybe we should make that full page too rather than container so i matches other pages. What do you think?

brittanyjoiner15 commented 1 year ago

@adsingh14 closing this out since we resolved the navbar, but if you want to make a separate issue for the full page on then FAQand home, go ahead and do that and ill assign to you!

adsingh14 commented 1 year ago

@brittanyjoiner15

As far as FAQs and Home page - that's a good catch. Maybe we should make that full page too rather than container so i matches other pages. What do you think?

I think FAQs page doesn't need to be changed except a minor change. It looks better in center. Yes, I'm working on home page offline and checking EUI docs.

--

Just curious, isn't this project covers 'hacktoberfest 2022'?

brittanyjoiner15 commented 1 year ago

@adsingh14 sounds good, and yes it does!

adsingh14 commented 1 year ago

sounds good, and yes it does!

I was asking because there's no label on either issue or my commit.

brittanyjoiner15 commented 1 year ago

@adsingh14 yep since the project has the topic hacktoberfest it's not need on every issue