brittanyrw / emojipages

EmojiPages is a listing of books and plays depicted through emojis.
https://emojipages.com/
Other
34 stars 102 forks source link

Add link to Goodreads to JavaScript in the app.js file #269

Closed brittanyrw closed 4 years ago

brittanyrw commented 5 years ago

If you would like to work on this Issue, comment below and wait for confirmation before starting to code.

In the app.js file, add a link around the emoji card title (the h3 element). This link should come from the data.js file objects from a key called itemLink. Make sure the link opens in a new tab when clicked.

The updated data.js objects should look like the following:

  {
    title: "Alexander Hamilton",
    author: "Ron Chernow",
    emojiImgs: "πŸ‡ΊπŸ‡Έβš”οΈπŸ’΅πŸ‘¨",
    genres: ["non-fiction", "biography"],
    year: 2004,
    itemLink: "https://www.goodreads.com/book/show/16130.Alexander_Hamilton"
  }

Therefore, when a user opens the card, the title of the book should be a clickable link to Goodreads.

See below for an image of the title that I am referring to:

Screen Shot 2019-10-08 at 9 20 39 AM

Add a Goodreads link to one book in data.js to test this out.

I will open Issues for others to add the links to the rest of the books.

To Do List:

rchavarria commented 5 years ago

Hi!

I'm looking forward to contribute to emojiscreen, emojipages or emoji* projects. I just saw this issue and it looks really interesting. It looks easy, but challenging at the same time for someone with not too much context on this project.

Would you mind if I spend some time implementing it?

brittanyrw commented 5 years ago

Hi @rchavarria, sure! I will assign this to you.