search

brittanyrw / emojipages

EmojiPages is a listing of books and plays depicted through emojis.
https://emojipages.com/
Other
34 stars 102 forks source link

Render link to GoodReads #281

Closed rchavarria closed 4 years ago

rchavarria commented 5 years ago
This PR handles the new property `itemLink` on each book entry and create a link with its value that opens in a new tab. It updates some docs too. The list of tasks addressed in the PR comes from the issue #269: - [x] Add an itemLink to one book in the data.js file for testing. - [x] Update the app.js file to add a link around the h3 element inside of title content. - [x] Update the card overview section in card_overview.md by updating the example object (add an itemLink for the existing example) and add a section for Link with instructions for how to add it to the object. - [x] Update the Card Pull Request Checklist section in card_overview.md and add a line for making sure they add a link. - [x] Update the object example in github_ui_walkthrough.md. - [x] Update the object example in local_dev_walkthrough.md. Closes #269
auto-comment[bot] commented 5 years ago

Thank you for opening this pull request, your code will be reviewed soon! Reminder, please follow the contribution guidelines outlined in the README. This Pull Request should be for an Issue that you have been assigned. If any updates need to be made, we will leave a comment for you here outlining exactly what you need to change for your pull request to be accepted. 💖