search

brittanyrw / emojipages

EmojiPages is a listing of books and plays depicted through emojis.
https://emojipages.com/
Other
34 stars 102 forks source link

Accessibility fix for emoji card on screen reader #286

Closed tummala-manasa closed 5 years ago

tummala-manasa commented 5 years ago

By making the emoji card a button and adding an aria-label, the screen reader would be able to identify it and read it as 'emoji card button'

Screen Shot 2019-10-03 at 12 23 14 PM

285

auto-comment[bot] commented 5 years ago

Thank you for opening this pull request, your code will be reviewed soon! Reminder, please follow the contribution guidelines outlined in the README. This Pull Request should be for an Issue that you have been assigned. If any updates need to be made, we will leave a comment for you here outlining exactly what you need to change for your pull request to be accepted. 💖

brittanyrw commented 5 years ago

@tummala-manasa Closing this because as stated in the README, we asked that you wait for confirmation and to be assigned an Issue before creating a pull request.