search

britter / bootify-testpyramid

Apache License 2.0
5 stars 2 forks source link

Remove explicit dependency on assertj-core #7

Closed michael-simons closed 6 years ago

michael-simons commented 6 years ago

It's part of the starter-test.

britter commented 6 years ago

Not sure I like this change. On the one hand it keeps the pom shorter. On the other hand I think your projects build should declare dependencies to everything it compiles against. Then again I would have to declare assertj version as well, to be in full control.

michael-simons commented 6 years ago

No offense taken :) I understand both positions. My point is pretty much clear on this slide: https://speakerdeck.com/michaelsimons/hinter-den-kulissen-die-magie-von-spring-boot?slide=13 I think that managing dependencies is one core feature of Spring Boot.

britter commented 6 years ago

@michael-simons I've thought about this and I realized, that I for example don't declare Hibernate even though I sometimes use Hibernate APIs in my projects. So my argument of having an explicit dependency is invalid.