search

britton-jb / sentinel

DEPRECATED - Phoenix Authentication library that wraps Guardian for extra functionality
MIT License
106 stars 19 forks source link

Add ability to set a custom callback after `AfterRegistrator` runs #38

Closed trestrantham closed 7 years ago

trestrantham commented 7 years ago

I am using this to kick off additional registration tasks after ueberauth creation has completed and thought it might be worth adding formally. Let me know if you have any feedback. 🤘

britton-jb commented 7 years ago

Sweet. I will have some time to look at this one in the next few days. I'll let you know if there are any changes that need made.

I really appreciate you taking the time to put up this PR, and it seems like this is likely worthwhile.

britton-jb commented 7 years ago

This is looking good. I'd like to add a spec for this if possible ensuring that the interface works, and to prevent this feature from being accidentally broken, but otherwise I'm feeling very good about this PR.

trestrantham commented 7 years ago

Sweet. I'll add specs for this and for https://github.com/britton-jb/sentinel/pull/40 hopefully this evening.

trestrantham commented 7 years ago

Specs added 🚦