britton-jb / sentinel

DEPRECATED - Phoenix Authentication library that wraps Guardian for extra functionality
MIT License
106 stars 19 forks source link

Uberauthenticator duplicate function with different bodies #54

Open erkattak opened 7 years ago

erkattak commented 7 years ago

The second of these two functions doesn't seem like it would ever run:

https://github.com/britton-jb/sentinel/blob/master/lib/sentinel/ueberauthenticator.ex#L29-L45

britton-jb commented 6 years ago

I believe they should be able to run, based on the guard clauses, but that would be easy to miss given how far off the page they run. I'll try to get a fix for that.

And sorry about the delay in response. Don't know how I missed this one.