search

brittonsmith / cloudy_cooling_tools

Create an N-dimensional grid of models with the Cloudy photoionization code.
MIT License
5 stars 4 forks source link

remove ability to specify output directory #4

Closed BenWibking closed 2 years ago

BenWibking commented 2 years ago

This ignores the outputDir parameter from the input .par file, and instead just sets the output directory to the current working directory (by setting outputDir = "").

This is required to use the current (July 2022) development version of Cloudy (available from https://gitlab.nublado.org/cloudy/cloudy/-/tree/master), which does not support writing output files anywhere except the current working directory.

Fixes https://github.com/brittonsmith/cloudy_cooling_tools/issues/3

brittonsmith commented 2 years ago

It looks like this was merged automatically as the change was included in PR #6, although then undone. Is this a change that you would like to see included? It's too bad that Cloudy no longer accepts an output directory. Is that a change that Cloudy developers intend to go with or is there a possibility is gets undone? If we're stuck with it, we may need to have the code change into the appropriate working directory. It's been a while since I've worked with this workflow so I'm curious to get your thoughts on this, @BenWibking.

BenWibking commented 2 years ago

That's a bit strange. I didn't mean to include this change in the other PR, so I reverted it there.

I think we might be stuck with this behavior in the upcoming version of Cloudy. Changing the working directory sounds like the best workaround to me.

brittonsmith commented 2 years ago

Ok, that's no problem. I don't know when I'll next be using an up to date cloudy, but if you'd care to implement this at some point, please feel free!