search

brittyazel / EnhancedRaidFrames

World of Warcraft addon to enhance the built-in raid frames with Grid like functionality!
https://www.curseforge.com/wow/addons/enhanced-raid-frame-indicators
MIT License
13 stars 7 forks source link

Add additional custom Range #103

Closed DoxAshe closed 1 year ago

DoxAshe commented 1 year ago

Solves issue #98

This is small but it lets people set their max range to 40 yards. Since 10.1 there have been some issues (I'm not sure if its from this addon or just from the game) with the out of range distance being set to the incorrect value.

brittyazel commented 1 year ago

Interesting, thanks for the PR. Is there a strong reason why you set the default custom range to 40 from 30? It doesn't 'really' matter, it was just interesting that that was part of your changes.

DoxAshe commented 1 year ago

I couldn't tell if it would be on by default, and I was worried if that was then for most classes the range indicators would be shorter than normal. I can revert that if you want, it probably didn't need to get changed.

brittyazel commented 1 year ago

Oh it's just the value that is set the first time someone toggles on that option. Unless the option is toggled on this value doesn't do anything. Which is why I said it doesn't 'really' matter if it's different, but in the grand scheme of things I do prefer 30 over 40 for the default, since the game default is already 40 (or supposed to be anyway).

DoxAshe commented 1 year ago

I've updated it to return the default to 30.