search

brittyazel / EnhancedRaidFrames

World of Warcraft addon to enhance the built-in raid frames with Grid like functionality!
https://www.curseforge.com/wow/addons/enhanced-raid-frame-indicators
MIT License
14 stars 8 forks source link

Defaulting to 'fallback' icon #35

Closed numbdig closed 4 years ago

numbdig commented 4 years ago

I am using this for Classic and it works great!

One problem I am encountering - for my name in the raid frames, if I do not have a raid icon assigned to me, a green box will appear. The fix for this is to give me a raid icon and then clear it - but it will periodically come back. Is there an easy fix for this?

image

brittyazel commented 4 years ago

Alrighty, I have no idea why this issue occurred in the first place, but this should effectively fix it!

numbdig commented 4 years ago

Thanks man! Just testing it outside of raid - it seems to be working :)

brittyazel commented 4 years ago

Excellent! 👍

brittyazel commented 4 years ago

Can you do me a favor? I added tentative support for libclassicdurations but I don't have any way to test it. Do you mind testing it out and seeing if spells on classic have the correct countdowns and whatnot with the changes I made? You'll have to snag the version from Github and install it manually

numbdig commented 4 years ago

Sure! I'll be back online later this evening and will let you know if it works at all.

numbdig commented 4 years ago

image Seems to be working :)

brittyazel commented 4 years ago

Great! Did the countdown not work prior?

numbdig commented 4 years ago

I just re-installed the previous version - CDs seem to be displaying just fine.

I did not test it extensively though - could LibClassicDurations have a full accounting of all spells that might be missing from the previous version?

brittyazel commented 4 years ago

I pushed a new release with these code changes immediately after you gave me to thumbs up, so it's likely if you reinstalled from Twitch/Curseforge you got the exact same version as here