search

brittyazel / EnhancedRaidFrames

World of Warcraft addon to enhance the built-in raid frames with Grid like functionality!
https://www.curseforge.com/wow/addons/enhanced-raid-frame-indicators
MIT License
14 stars 8 forks source link

Timer for Greater Heal HOT (from priest t2 8/8) not working for other players #55

Closed Anilusion closed 4 years ago

Anilusion commented 4 years ago

image The timer for Greater Heal HOT only shows if the heal is cast on yourself, not if you cast it on other players. The HOT has a proper duration on the target frame, but not in a raid frame indicator.

brittyazel commented 4 years ago

This seems like a libclassicdurations issue. In general, the game doesn't allow players in classic to query the length of other player's auras. A workaround for this is to use libclassicdurations, which is a library of how long each aura should last. What you are witnessing is the intended behavior by Blizzard. I'll check to see if libclassicdurations has an update for this, but it's outside of my control unfortunately, so I suggest you file that bug report with them directly

Anilusion commented 4 years ago

It's strange though, since the timer on my targetframe works (default unit frames), but the timer for the icon this addon creates does not.

brittyazel commented 4 years ago

It's just a limitation with Classic. The function that we use to get the length left on a buff, UnitAura(), is banned from returning that information to us. Hence why libclassicdurations exists. I don't make the rules sadly, this was a conscious choice Blizzard made.

brittyazel commented 4 years ago

I just pushed a new version of libclassicdurations to MASTER. Can you download the .zip here from Github, install it, test and see if that fixes your issue? If not, I suggest taking it up with the libclassicdurations author, and I'll gladly add his fixed version once the change is made

Anilusion commented 4 years ago

Awesome, it works with the latest version! Thank you.

brittyazel commented 4 years ago

👍