brittyazel / EnhancedRaidFrames

World of Warcraft addon to enhance the built-in raid frames with Grid like functionality!
https://www.curseforge.com/wow/addons/enhanced-raid-frame-indicators
MIT License
14 stars 8 forks source link

Addon does not function in Classic #75

Closed ghost closed 3 years ago

ghost commented 3 years ago

Issue description:

This addon lacks functionality when enabled and causes an error to be displayed after loading into the game from the login screen.

How to reproduce:

  1. Open WoW classic with addon installed
  2. Observe

Technical info:

Additional context:

Error is displayed with no other addons enabled. Also, this issue did not occur in addon version 3.35

Screenshots:

Capture

Lua error log:

Message: ...ace\AddOns\EnhancedRaidFrames\EnhancedRaidFrames.lua:40: attempt to call global 'CreateColorFromHexString' (a nil value)
Time: Wed Jan 20 22:14:04 2021
Count: 1
Stack: ...ace\AddOns\EnhancedRaidFrames\EnhancedRaidFrames.lua:40: attempt to call global 'CreateColorFromHexString' (a nil value)
...ace\AddOns\EnhancedRaidFrames\EnhancedRaidFrames.lua:40: in main chunk

Locals: addonName = "EnhancedRaidFrames"
addonTable = <table> {
 EnhancedRaidFrames = <table> {
 }
}
EnhancedRaidFrames = <table> {
 SetDefaultModuleLibraries = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:367
 Enable = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:294
 NewModule = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:235
 EnableModule = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:332
 modules = <table> {
 }
 CancelTimer = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceTimer-3.0\AceTimer-3.0.lua:147
 IterateEmbeds = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:442
 SecureHook = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceHook-3.0\AceHook-3.0.lua:336
 defaultModuleLibraries = <table> {
 }
 TimeLeft = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceTimer-3.0\AceTimer-3.0.lua:172
 GetName = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:279
 UnregisterChatCommand = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceConsole-3.0\AceConsole-3.0.lua:111
 RawHookScript = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceHook-3.0\AceHook-3.0.lua:395
 ScheduleRepeatingTimer = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceTimer-3.0\AceTimer-3.0.lua:129
 CancelAllTimers = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceTimer-3.0\AceTimer-3.0.lua:160
 Printf = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceConsole-3.0\AceConsole-3.0.lua:69
 RED_COLOR = <table> {
 }
 SetDefaultModulePrototype = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:409
 NORMAL_COLOR = <table> {
 }
 DATABASE_VERSION = 2
 isWoWClassic = true
 name = "EnhancedRaidFrames"
 auraStrings = <table> {
 }
 IsEnabled = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:451
 orderedModules = <table> {
 }
 ScheduleTimer = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceTimer-3.0\AceTimer-3.0.lua:94
 DisableModule = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceAddon-3.0\AceAddon-3.0.lua:350
 Print = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceConsole-3.0\AceConsole-3.0.lua:54
 GetArgs = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceConsole-3.0\AceConsole-3.0.lua:144
 RegisterChatCommand = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceConsole-3.0\AceConsole-3.0.lua:85
 allAuras = " "
 RegisterMessage = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
 HookScript = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceHook-3.0\AceHook-3.0.lua:366
 RegisterBucketEvent = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceBucket-3.0\AceBucket-3.0.lua:184
 UnregisterAllBuckets = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceBucket-3.0\AceBucket-3.0.lua:229
 IsHooked = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceHook-3.0\AceHook-3.0.lua:493
 UnregisterBucket = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceBucket-3.0\AceBucket-3.0.lua:206
 RegisterBucketMessage = <function> defined @Interface\AddOns\EnhancedRaidFrames\Libs\AceBucket-3.0\AceBucket-3.0.lua:200
 IsModule = <function> defined @Interface\Add
brittyazel commented 3 years ago

Ugh seriously? Classic doesn't have the Color-Mixin. I'm so tired of Wow classic.

ghost commented 3 years ago

:( I do not play retail at all, so if you ever need anything tested in classic, please feel free to let me know.

brittyazel commented 3 years ago

This should be fixed. Please test the latest MASTER version report back if it sorts it out in Classic.

There are missing functions in Classic that we have access to in Retail. We have to now manually declare those functions for use in Classic up until Blizz unifies the codebases.

ghost commented 3 years ago

Everything seems to be working perfectly again in 3.37. Thank you! :)