search

brittyazel / Neuron

A full-featured World of Warcraft action bar and interface replacement addon
https://www.curseforge.com/wow/addons/neuron
MIT License
31 stars 21 forks source link

0.9.14a : Faction reward #32

Open SirLagardere opened 6 years ago

SirLagardere commented 6 years ago

Hi, I don't know if the "Reward" text should appeared when you've got the Bonus Faction package, but if it sould, it's not "working" on my side : image

brittyazel commented 6 years ago

Yeah it should. Apparently it's not working heh. I'll look at it tonight

On Jan 9, 2018 10:13 AM, "SirLagardere" notifications@github.com wrote:

Hi, I don't know if the "Reward" text should appeared when you've got the Bonus Faction package, but if it sould, it's not "working" on my side : [image: image] https://user-images.githubusercontent.com/20615278/34735828-15f9e6a0-f571-11e7-9293-6610f0af61af.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/brittyazel/Neuron/issues/32, or mute the thread https://github.com/notifications/unsubscribe-auth/ADkuE4bzChZEkeFKDGU-RUA9BPNgDP8eks5tI6xIgaJpZM4RYO8- .

brittyazel commented 6 years ago

Strange I don't know why it's not showing. The code looks correct. I didn't t have any rewards yet so I've yet to see it myself.

SirLagardere commented 6 years ago

So, on my last reward, the text appears : image But, as I reclaim it, the text persists until a new reputation gain (maybe it's a bug on Blizzard side)

brittyazel commented 6 years ago

Is this still an issue? I never followed up to see if my fix worked

SirLagardere commented 6 years ago

I need to check it carrefully, but as far as I know, there still a problem. It seems to be updated only after another gain. So for example if I can get a reward, it will only be updated when I gain reputation again. And when I have the alert and collect the reward, it's still marked on the bar.

SirLagardere commented 6 years ago

Another thing, the faction rank is not translated (ie exalted stay exalted, not localized)

SirLagardere commented 6 years ago

So as far as I know the problem is still there. Don't know if it's a problem on Blizzard side or not but the reward highlight is always delayed by one reputation gain (ie : reward available, reputation gain, highlight on, reward claimed, reputation gain, highlight off)

brittyazel commented 6 years ago

lol ok I'll finally figure this one out. I'll go out and farm some world quests until I get the reward, I've been putting off doing world quests for a long time lol

brittyazel commented 6 years ago

Ok so the issue is that the text that says "reward" won't change until a /reload. I just need to add a check to some sort of onevent call