brittyazel / Neuron

A full-featured World of Warcraft action bar and interface replacement addon
https://www.curseforge.com/wow/addons/neuron
MIT License
30 stars 20 forks source link

Cooldowns on toys not showing #350

Open TruthNZ opened 4 years ago

TruthNZ commented 4 years ago

As per the topic.

Particularly missing it on my hearthstone toys.

brittyazel commented 4 years ago

Hrm my hearthstone toys all show cooldowns... can you drag the toy off and redrop it on from the toy menu? I did some work so maybe it needs to be re-placed to take effect

TruthNZ commented 4 years ago

It's a fresh install of WoW with addons only just installed and setup.

brittyazel commented 4 years ago

hrm. Odd. I'm testing cooldowns for my hearthstone toys and I'm confirming that the cooldown shows

brittyazel commented 4 years ago

Can you try the code in MASTER?

brittyazel commented 4 years ago

And do you mind pasting me the macro text so I can just verify what the contents are?

TruthNZ commented 4 years ago

Tried Master branch, same issue.

Auto created Macro is just: /use Greatfather Winter's Hearthstone

I've also tried putting putting a #showtooltip in as well, also no luck.

I'm also getting the same issue with items from my bags not showing their cooldowns.

And I've tried doing a complete profile reset, still no luck.

TruthNZ commented 4 years ago

Actually for #showtooltip, I'm not getting a picture either. I've tried both:

showtooltip item:162973

and

showtooltip Greatfather Winter's Hearthstone

I'd just to check, I unloaded all other addons, still no cooldown showing. I'm also not seeing the cooldown in the mouseover tooltip. And I confirmed that if I unload Neuron, and use the base blizz bars I am seeing the cooldowns with fine (for both toys dragged onto the base action bars, and macro's with #showtooltip for them).

brittyazel commented 4 years ago

...uh #showtooltip is giving me a picture just fine, and I cannot for the life of me replicate 'not' getting a cooldown for that button. Is there anything special about the bar?

brittyazel commented 4 years ago

Annotation 2020-04-26 003241 Just to prove I'm not lying to you lol

TruthNZ commented 4 years ago

image

Standard Action Bar. Turned off the Macro Name, and turned on Cooldown Count. But have tried with default settings for a new bar.

TruthNZ commented 4 years ago

Ok, just to make sure there was no interactions going on, or old code: I've completely deleted my interfaces and WTF folders (after backing up of course), and installed only Neuron from the master branch. Still no go.

brittyazel commented 4 years ago

Ok I'm just taking stabs in the dark. Can you try MASTER please, I just made a change?

TruthNZ commented 4 years ago

That did it!

brittyazel commented 4 years ago

Woot! I actually figured out the 'real' problem. I was looking for the item in the item cache using the name with capitals in it, rather than just lower case which is how I save it to the cache lol. Such a stupid error. Capital letters vs lowercase letters.

TruthNZ commented 4 years ago

So a further wrinkle in this issue. It works for toys I've dropped onto an action bar somewhere. But not for anything with just the #showtooltip part (a macro I've setup), unless that toy is somewhere on another action bar elsewhere :(

(I've got a self-modifying macro for random hearthstones. It'll show the tooltips for ones I've dropped onto an actionbar elsewhere, but not for ones that aren't)

Don't know if you want to reopen this, or raise as a new issue.

brittyazel commented 4 years ago

It's cool, I can add some more logic perhaps. Thanks for figuring this out. Can you paste the random hearthstone code here so I can test it with your exact macro?

TruthNZ commented 4 years ago

I'm using this addon: https://www.curseforge.com/wow/addons/randomhearthstone It's got a script it executes which modifies the macro every time you run it (Which thankfully seems to update the version dropped onto an action bar too).

brittyazel commented 4 years ago

Please test MASTER. I just added a fix that might address this

TruthNZ commented 4 years ago

Will do when I get home from work tonight (so 5ish hours).

TruthNZ commented 4 years ago

Ok, so it works if I use the Neuron Macro editor.

If I create a Macro in the Base UI editor, and then drag drop it onto a bar, then it doesn't work.

Unfortunately, if I create the Macro directly in the Neuron Editor, the addon doesn't pick it up and updated it :(