search

brittyazel / Neuron

A full-featured World of Warcraft action bar and interface replacement addon
https://www.curseforge.com/wow/addons/neuron
MIT License
31 stars 21 forks source link

Fix item tooltips flashing for an instant in BCC #424

Closed Nephyrin closed 2 years ago

Nephyrin commented 3 years ago

Calling GameTooltip:SetHyperlink twice with the same link causes it to hide itself, for reasons unknown.

Compare first, do nothing if it's already showing this.

I wasn't able to easily test the fallthrough case where we're passing an unknown item fragment in -- there might still be a flash when the tooltip would otherwise read "Retrieving Item Information...". I'm not sure what :GetItem() would return in that case to compare though, we'd need more specific tracking of when we show/hide the tooltip and what we asked it to display.

crosenbe commented 2 years ago

Thanks a lot, works perfectly. This fix issue #354.

AlexFolland commented 2 years ago

Any progress on merging this? It'd be nice if this was mainlined.

brittyazel commented 2 years ago

This was merged into NeuronNext