Closed ylixir closed 2 years ago
So far so good, just a few notes. I think I would prefer if the config options were the root element of the UI, not the profiles. I just find it a little odd to have that be the first thing you see, when (in theory) the config toggles are the more often used settings to tweak. If we could switch those two around, that would be awesome.
Also, on the config options page, the use of the two column view is a bit odd, given we only have a single set of options to show. I understand that this is probably future-proofing for more controls moving forward, but for now it took me a second to understand what the two columns were trying to tell me lol.
I also noticed on line 16 on Neuron-Startup.lua you reference a 'barClass' variable that doesn't exist, and this is throwing errors if you try to reset the database.
Lastly, connected to the above, resetting the database from the profiles page no longer prompts you to reload UI (or do anything really). You have to knowingly reload the UI for anything to happen.
I wound up completely disabling flyouts and [classic] shaman bars
flyouts are broken anyhow, and shaman bars are not implemented so there is no point hiding them