search

brittyazel / Neuron

A full-featured World of Warcraft action bar and interface replacement addon
https://www.curseforge.com/wow/addons/neuron
MIT License
31 stars 21 forks source link

Having Blizzard Actionbars hidden in settings prevents ExtraActionButton from showing #477

Open Ketrel opened 2 years ago

Ketrel commented 2 years ago

How to reproduce / Issue description:**

  1. Ensure that in the "Display the Blizzard UI" settings ActionBar is unchecked and Extra Action Bar is checked

Results: Extra Action Button is NOT displayed
Expected Results: Extra Action Button is displayed

Technical info:

Additional context:

I've traced it to line 87 in Neuron-DisableBlizzardUI.lua which runs when Blizzard ActionBars are set to be hidden 

ActionBarController:UnregisterAllEvents()

The comment says that's to avoid potential for taints, but it unfortunately looks like it also prevents whatever event would show the blizzard extra action button.

ylixir commented 2 years ago

i haven't figured out a good place to test the extra action button (or the zone buttons)

this isn't happening at a place that would be easy for me to test is it?

brittyazel commented 2 years ago

Suramar City will activate both the Extra Button and the zone ability button

Ketrel commented 2 years ago

I used Suramar for my testing to isolate the line causing the issue.

For zone, Draenor Garrison works as that's just zone, not extra.

ylixir commented 2 years ago

add vehicle exit button to this list as well