brittyazel / Neuron

A full-featured World of Warcraft action bar and interface replacement addon
https://www.curseforge.com/wow/addons/neuron
MIT License
31 stars 21 forks source link

Error with overlays creating new bars #498

Open ylixir opened 1 year ago

ylixir commented 1 year ago

Issue description:

Creating a new bar while editing bars throws an null exception. Probably because the bar has no overlay, now that overlays are created dynamically. same deal when the overlays try to clean themselves up

How to reproduce:

  1. left click minimap icon
  2. choose a new bar type (cast bar was my choice)
  3. error!
  4. close dialog
  5. error!

Lua error log:

1x Neuron/Overlay/BarEditor.lua:215: attempt to index local 'overlay' (a nil value)
[string "@Neuron/Overlay/BarEditor.lua"]:215: in function `activate'
[string "@Neuron/Objects/Bar.lua"]:303: in function `ChangeSelectedBar'
[string "@Neuron/Objects/Bar.lua"]:167: in function `CreateNewBar'
[string "@Neuron/GUI/BarEditTab.lua"]:96: in function <Neuron/GUI/BarEditTab.lua:96>
[string "=[C]"]: ?
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <0ViragDevTool/Libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/widgets/AceGUIWidget-Button.lua"]:22: in function <...Tool/Libs/AceGUI-3.0/widgets/AceGUIWidget-Button.lua:19>
3x Neuron/Objects/StatusButton.lua:337: attempt to call method 'cFunc' (a nil value)
[string "@Neuron/Objects/StatusButton.lua"]:337: in function `UpdateStatus'
[string "@Neuron/Objects/Bar.lua"]:1320: in function `UpdateObjectStatus'
[string "@Neuron/Neuron.lua"]:411: in function `ToggleBarEditMode'
[string "@Neuron/GUI/MainWindow.lua"]:79: in function `DestroyEditor'
[string "@Neuron/GUI/MainWindow.lua"]:59: in function <Neuron/GUI/MainWindow.lua:59>
[string "=[C]"]: ?
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <0ViragDevTool/Libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/widgets/AceGUIContainer-Frame.lua"]:29: in function <...ol/Libs/AceGUI-3.0/widgets/AceGUIContainer-Frame.lua:28>
[string "=[C]"]: in function `Hide'
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/widgets/AceGUIContainer-Frame.lua"]:125: in function `Hide'
[string "@0ViragDevTool/Libs/AceGUI-3.0-41/widgets/AceGUIContainer-Frame.lua"]:21: in function <...ol/Libs/AceGUI-3.0/widgets/AceGUIContainer-Frame.lua:19>