search

britzl / extension-imgui

Dear ImGUI extension for Defold
MIT License
58 stars 19 forks source link

Compilation errors in stb_image on iOS #12

Closed dri-richard closed 1 year ago

dri-richard commented 3 years ago

WARNING: imgui/src/imgui/stb_image.h(592): expanded from macro 'STBI_THREAD_LOCAL' ERROR: imgui/src/imgui/stb_image.h:1070: 'thread-local storage is not supported for the current target'

define STBI_THREAD_LOCAL thread_local

britzl commented 3 years ago

Yep, the extension is currently untested on iOS

dri-richard commented 3 years ago

I should have been clearer - I saw the support was 'unknown' on iOS but I thought it possible that it might work.

britzl commented 3 years ago

I should have been clearer - I saw the support was 'unknown' on iOS but I thought it possible that it might work.

Got it! I think it's possible to fix the issue and make it run on iOS as well.

britzl commented 3 years ago

I'm actually not getting any build errors on 1.2.185 (where we updated the iOS SDK version). Closing.

dri-richard commented 3 years ago

I see the same issues with 1.2.185.

Building the example project - this is on my Windows PC, but I see the same results on our game project with a Github Actions MacOS runner.

D:\User Documents\Richard\Defold projects\extension-imgui-master>java -jar d:\Installs\Defold_1.2.185\bob.jar --platform armv7-darwin --verbose resolve distclean build --archive bundle

produces:



ERROR: imgui/src/imgui/stb_image.h:931: 'thread-local storage is not supported for the current target
STBI_THREAD_LOCAL'

INFO: imgui/src/imgui/stb_image.h:592: 'expanded from macro 'STBI_THREAD_LOCAL'
      #define STBI_THREAD_LOCAL       thread_local'

ERROR: imgui/src/imgui/stb_image.h:1070: 'thread-local storage is not supported for the current target
static STBI_THREAD_LOCAL int stbi__vertically_flip_on_load_local, stbi__vertically_flip_on_load_set;'

INFO: imgui/src/imgui/stb_image.h:592: 'expanded from macro 'STBI_THREAD_LOCAL'
      #define STBI_THREAD_LOCAL       thread_local'

ERROR: imgui/src/imgui/stb_image.h:1070: 'thread-local storage is not supported for the current target'

INFO: imgui/src/imgui/stb_image.h:592: 'expanded from macro 'STBI_THREAD_LOCAL'
      #define STBI_THREAD_LOCAL       thread_local'```
dri-richard commented 3 years ago

Well... I can get it to build by removing 32bit support, but that's not the default.

britzl commented 3 years ago

We will remove 32-bit as the iOS devices with 32-bit architecture actually do not support OpenGL3 (which we migrated to recently). We have refrained from removing 32-bit support as it would impact updates to already released iOS games.